linux-kernel - Re: [RFC PATCH 2/3 v2] perf: Implement Nehalem uncore pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=qDsNwVAoHF=x62C8x=x3cGaobTZNDGHDr8YZ+@mail.gmail.com>
Date:	Wed, 1 Dec 2010 14:04:44 +0100
From:	Stephane Eranian <eranian@...gle.com>
To:	Lin Ming <ming.m.lin@...el.com>
Cc:	Don Zickus <dzickus@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, Andi Kleen <andi@...stfloor.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [RFC PATCH 2/3 v2] perf: Implement Nehalem uncore pmu

On Wed, Dec 1, 2010 at 4:21 AM, Lin Ming <ming.m.lin@...el.com> wrote:
>
> On Fri, 2010-11-26 at 18:06 +0800, Stephane Eranian wrote:
> > On Fri, Nov 26, 2010 at 10:00 AM, Lin Ming <lin@...g.vg> wrote:
> > > On Fri, Nov 26, 2010 at 4:33 PM, Stephane Eranian <eranian@...gle.com> wrote:
> > >> Lin,
> > >>
> > >> Looked at the perfmon code, and it seems the mask is actual
> > >> cores, not threads:
> > >>                rdmsrl(MSR_NHM_UNC_GLOBAL_CTRL, val);
> > >>                val |= 1ULL << (48 + cpu_data(smp_processor_id()).cpu_core_id);
> > >>                wrmsrl(MSR_NHM_UNC_GLOBAL_CTRL, val);
> > >>
> > >> That seems to imply both threads will get the interrupt.
> > >>
> > >> In the the overflowed event was programmed from on of the two threads, that
> > >> means one will process the overflow, the other will get spurious.
> > >>
> > >> On the cores where no uncore was programmed, then both threads will have
> > >> a spurious interrupt.
> > >
> > > But in my test, if HT is on, only the 2 theads in one of the four cores
> > > will receive the interrupt. Even worse, we don't know which core will
> > > receive the interrupt
> > > when overflow happens.
> > >
> > The MSR_NHM_UNC_GLOBAL_CTRL is per socket not per core.
>
> Understood.
>
> >
> > > I'll do more tests to verify this.
> >
> > In your tests, are your programming the same uncore event
> > across all CPUs? If so then you may have a race condition
> > setting the MSR because it read-modify-write.
> >
> > What about you program only one uncore event from one CPU?
>
> This is what I tested, programming only one uncore event from one CPU.

> When HT is off, all four cores in the socket receive the interrupt.

If the value of the MSR is 0xf << 48?

> When HT is on, only the 2 threads in one of the four cores receive the
> interrupt.
Something is not right here. Next week, I may be able to run some tests
on a Nehalem using perfmon to compare. Could you also send me your
latest uncore patch against tip-x86?
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/