linux-kernel - Re: [PATCH] perf: add csv-style output to perf stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=C0FX2f-SS65p9nXWB8ogNqtgJVa8e+N6C32+5@mail.gmail.com>
Date:	Wed, 1 Dec 2010 18:24:46 +0100
From:	stephane eranian <eranian@...glemail.com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Stephane Eranian <eranian@...gle.com>,
	linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu,
	paulus@...ba.org, davem@...emloft.net, fweisbec@...il.com,
	perfmon2-devel@...ts.sf.net, robert.richter@....com
Subject: Re: [PATCH] perf: add csv-style output to perf stat

On Wed, Dec 1, 2010 at 6:06 PM, Arnaldo Carvalho de Melo
<acme@...stprotocols.net> wrote:
> Em Wed, Dec 01, 2010 at 05:00:05PM +0200, Stephane Eranian escreveu:
>> This patch adds an option (-x) to print counts using a CSV-style output.
>> This makes it very easy to import counts directly into your favorite
>> spreadsheet without having to write scripts.
>
> I was about to work on this :-) I think we should use the same option
> 'report' uses:
>
>    OPT_STRING('t', "field-separator", &symbol_conf.field_sep, "separator",
>               "separator for columns, no spaces will be added between "
>               "columns '.' is reserved."),
>
> [root@...a ~]# perf record -F 100000 ls > /dev/null
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.041 MB perf.data (~1798 samples) ]
> [root@...a ~]# perf report --stdio -t, | head -10
> # Events: 1K cycles
> #
> # Overhead,Command,Shared Object,Symbol
> 52.57,    ls,libc-2.5.so      ,[.] __GI___strcoll_l
> 3.97,    ls,ls               ,[.]             24a2
> 3.48,    ls,libc-2.5.so      ,[.] __GI_strlen
> 2.33,    ls,[ext3]           ,[k] ext3fs_dirhash
> 2.21,    ls,[kernel.kallsyms],[k] clear_page_c
> 1.94,    ls,[ext3]           ,[k] ext3_htree_store_dirent
> 1.81,    ls,[kernel.kallsyms],[k] rt_spin_lock_fastunlock
> [root@...a ~]#
>
> Spaces are being added, gack, will fix. Tried to use the same option letter and
> long option name as in 'sort':
>
>       -t, --field-separator=SEP
>              use SEP instead of non-blank to blank transition
>
> But then 'perf stat' already uses -t for --tid, so in 'stat' we would have to
> use '-x'/--field-separator.
>
Fine with me.
I can re-spin the patch to add the flexibility to name your SEP.

> Argh, I think we should stop using short options, only assigning something when
> it gets from seldomly used to just before making it the default 8-)

I tend to use the short options....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/