linux-kernel - Re: [Intel-gfx] [PATCH 1/4] drm: fix headers to include linux/types.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikYmVQ3A+DArFq+7z1MvhZDR6z+3-VdJpoRMV1K@mail.gmail.com>
Date:	Thu, 2 Dec 2010 05:55:59 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Julien Cristau <jcristau@...ian.org>,
	Alexander Shishkin <virtuoso@...nd.org>,
	intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/4] drm: fix headers to include linux/types.h

On Thu, Dec 2, 2010 at 5:38 AM, Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Wed, 1 Dec 2010 17:54:18 +0100
> Julien Cristau <jcristau@...ian.org> wrote:
>
>> On Wed, Dec  1, 2010 at 17:10:42 +0200, Alexander Shishkin wrote:
>>
>> > For headers that get exported to userland and make use of u32 style
>> > type names, it is advised to include linux/types.h.
>> >
>> > This fixes 5 headers_check warnings.
>> >
>> How many times does this need to be NAKed?
>
> Until someone gets a clue and puts comments in there explaining this?

how about someone fixing the dumb scripts to understand that C header
includes aren't single level.

Like 10 people have posted this patch and not one has come back with a
fix for the app after I pointed it out, like really if people think
they can write C good enough to send kernel patches,
maybe they could put some more effort in and actually fix a real problem.

We should start hashing signed-off-by's so people can't get any glory from them.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/