linux-kernel - Re: [PATCH v4] sched: automated per session task groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CF5C379.8030204@google.com>
Date:	Tue, 30 Nov 2010 19:39:37 -0800
From:	Paul Turner <pjt@...gle.com>
To:	Mike Galbraith <efault@....de>
CC:	Ingo Molnar <mingo@...e.hu>, Oleg Nesterov <oleg@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] sched: automated per session task groups

On 11/28/10 06:24, Mike Galbraith wrote:
> On Thu, 2010-11-25 at 09:00 -0700, Mike Galbraith wrote:
>
>> My vacation is (sniff) over, so I won't get a fully tested patch out the
>> door for review until I get back home.
>
> Either I forgot to pack my eyeballs, or laptop is just too dinky and
> annoying.  Now back home on beloved box, this little bugger poked me
> dead in the eye.
>
> Something else is seriously wrong though.  36.1 with attached (plus
> sched, cgroup: Fixup broken cgroup movement) works a treat, whereas
> 37.git and tip with fixlet below both suck rocks.  With a make -j40
> running, wakeup-latency is showing latencies of>100ms, amarok skips,
> mouse lurches badly.. generally horrid.  Something went south.
>

I'm looking at this.

The share:share ratios looked good in static testing, but perhaps we 
need a little more wake-up boost to improve interactivity.

Should have something tomorrow.

- Paul

> sched: fix 3d4b47b4 typo.
>
> Signed-off-by: Mike Galbraith<efault@....de>
> Cc: Peter Zijlstra<a.p.zijlstra@...llo.nl>
> Cc: Ingo Molnar<mingo@...e.hu>
> LKML-Reference: new submission
> ---
>   kernel/sched.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> Index: linux-2.6/kernel/sched.c
> ===================================================================
> --- linux-2.6.orig/kernel/sched.c
> +++ linux-2.6/kernel/sched.c
> @@ -8087,7 +8087,6 @@ static inline void unregister_fair_sched
>   {
>   	struct rq *rq = cpu_rq(cpu);
>   	unsigned long flags;
> -	int i;
>
>   	/*
>   	* Only empty task groups can be destroyed; so we can speculatively
> @@ -8097,7 +8096,7 @@ static inline void unregister_fair_sched
>   		return;
>
>   	raw_spin_lock_irqsave(&rq->lock, flags);
> -	list_del_leaf_cfs_rq(tg->cfs_rq[i]);
> +	list_del_leaf_cfs_rq(tg->cfs_rq[cpu]);
>   	raw_spin_unlock_irqrestore(&rq->lock, flags);
>   }
>   #else /* !CONFG_FAIR_GROUP_SCHED */
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/