linux-kernel - Re: [PATCH 2/3] lib: Improve EWMA efficiency by using bitshifts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1291285222.3481.45.camel@jlt3.sipsolutions.net>
Date:	Thu, 02 Dec 2010 11:20:22 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Bruno Randolf <br1@...fach.org>
Cc:	linville@...driver.com, randy.dunlap@...cle.com, br1@...nktube.com,
	peterz@...radead.org, blp@...stanford.edu,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	Lars_Ericsson@...ia.com, j@...fi, stefanr@...6.in-berlin.de,
	kosaki.motohiro@...fujitsu.com, akpm@...ux-foundation.org,
	kevin.granade@...il.com
Subject: Re: [PATCH 2/3] lib: Improve EWMA efficiency by using bitshifts

On Thu, 2010-12-02 at 19:12 +0900, Bruno Randolf wrote:

> +	/* get bitshift for weight */
> +	for (n = 0; !(weight & 1); n++)
> +		weight = weight >> 1;
> +	WARN_ON(weight > 1 || n < 1);

I'm sure there's something like log2() (and is_power_of_2() for the
warning) in the kernel already -- no need to reimplement it...

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/