linux-kernel - Re: [7/8, v6] NUMA Hotplug Emulator: extend memory probe interface to support NUMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1012011653530.1896@chino.kir.corp.google.com>
Date:	Wed, 1 Dec 2010 16:55:42 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Shaohui Zheng <shaohui.zheng@...el.com>
cc:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, haicheng.li@...ux.intel.com,
	lethal@...ux-sh.org, ak@...ux.intel.com,
	shaohui.zheng@...ux.intel.com, dave@...ux.vnet.ibm.com,
	gregkh@...e.de, Haicheng Li <haicheng.li@...el.com>,
	Wu Fengguang <fengguang.wu@...el.com>
Subject: Re: [7/8, v6] NUMA Hotplug Emulator: extend memory probe interface
 to support NUMA

On Tue, 30 Nov 2010, shaohui.zheng@...el.com wrote:

> From: Shaohui Zheng <shaohui.zheng@...el.com>
> 
> Extend memory probe interface to support an extra paramter nid,
> the reserved memory can be added into this node if node exists.
> 
> Add a memory section(128M) to node 3(boots with mem=1024m)
> 
> 	echo 0x40000000,3 > memory/probe
> 
> And more we make it friendly, it is possible to add memory to do
> 
> 	echo 3g > memory/probe
> 	echo 1024m,3 > memory/probe
> 
> It maintains backwards compatibility.
> 
> Another format suggested by Dave Hansen:
> 
> 	echo physical_address=0x40000000 numa_node=3 > memory/probe
> 
> it is more explicit to show meaning of the parameters.
> 

I don't like this interface, I think it would be much better to map the 
memory region to the desired node id prior to using probe as an extention 
to debugfs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/