linux-kernel - Re: [PATCH 1/2] ath: Fix ath_dbg uses missing newlines and access beyond array bound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101202190239.GE7399@tux>
Date:	Thu, 2 Dec 2010 11:02:39 -0800
From:	"Luis R. Rodriguez" <lrodriguez@...eros.com>
To:	Joe Perches <joe@...ches.com>
CC:	Luis Rodriguez <Luis.Rodriguez@...eros.com>,
	Jouni Malinen <Jouni.Malinen@...eros.com>,
	Vasanth Thiagarajan <Vasanth.Thiagarajan@...eros.com>,
	Senthilkumar Balasubramanian 
	<Senthilkumar.Balasubramanian@...eros.com>,
	"John W. Linville" <linville@...driver.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"ath9k-devel@...ts.ath9k.org" <ath9k-devel@...ts.ath9k.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ath: Fix ath_dbg uses missing newlines and access
 beyond array bound

On Wed, Dec 01, 2010 at 09:13:32PM -0800, Joe Perches wrote:
> Add missing newlines to ath_dbg uses
> ar9300RateSize is not a power of 4, fix to print array line by line.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/net/wireless/ath/ath9k/ar9003_eeprom.c |   29 ++---------------------
>  drivers/net/wireless/ath/ath9k/calib.c         |    4 +-
>  drivers/net/wireless/ath/ath9k/gpio.c          |    6 ++--
>  drivers/net/wireless/ath/ath9k/htc_drv_gpio.c  |    7 ++---
>  drivers/net/wireless/ath/ath9k/htc_drv_main.c  |    2 +-
>  5 files changed, 12 insertions(+), 36 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> index e6ae62b..beb3e87 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> @@ -3342,7 +3342,7 @@ static int ar9300_eeprom_restore_internal(struct ath_hw *ah,
>  	goto fail;
>  
>  found:
> -	ath_dbg(common, ATH_DBG_EEPROM, "Found valid EEPROM data");
> +	ath_dbg(common, ATH_DBG_EEPROM, "Found valid EEPROM data\n");
>  
>  	for (it = 0; it < MSTATE; it++) {
>  		if (!read(ah, cptr, word, COMP_HDR_LEN))
> @@ -4084,22 +4084,9 @@ static void ar9003_hw_set_target_power_eeprom(struct ath_hw *ah, u16 freq,
>  	    ar9003_hw_eeprom_get_ht40_tgt_pwr(ah, HT_TARGET_RATE_23, freq,
>  					      is2GHz) + ht40PowerIncForPdadc;
>  
> -	while (i < ar9300RateSize) {
> -		ath_dbg(common, ATH_DBG_EEPROM,
> -			"TPC[%02d] 0x%08x ", i, targetPowerValT2[i]);
> -		i++;
> -
> -		ath_dbg(common, ATH_DBG_EEPROM,
> -			"TPC[%02d] 0x%08x ", i, targetPowerValT2[i]);
> -		i++;
> -
> -		ath_dbg(common, ATH_DBG_EEPROM,
> -			"TPC[%02d] 0x%08x ", i, targetPowerValT2[i]);
> -		i++;
> -
> +	for (i = 0; i < ar9300RateSize; i++) {
>  		ath_dbg(common, ATH_DBG_EEPROM,
>  			"TPC[%02d] 0x%08x\n", i, targetPowerValT2[i]);
> -		i++;
>  	}
>  }

Please send this hunk on a separate patch.

  Luis
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/