linux-kernel - Re: [PATCH] PM: Prevent dpm_prepare() from returning errors unnecessarily

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201012022042.31954.rjw@sisk.pl>
Date:	Thu, 2 Dec 2010 20:42:31 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	"Linux-pm mailing list" <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ming Lei <tom.leiming@...il.com>
Subject: Re: [PATCH] PM: Prevent dpm_prepare() from returning errors unnecessarily

On Thursday, December 02, 2010, Alan Stern wrote:
> On Thu, 2 Dec 2010, Rafael J. Wysocki wrote:
> 
> > OK, so please let me know what you think of the appended patch (on top of the
> > previous one).
> > 
> > Thanks,
> > Rafael
> > Index: linux-2.6/include/linux/suspend.h
> > ===================================================================
> > --- linux-2.6.orig/include/linux/suspend.h
> > +++ linux-2.6/include/linux/suspend.h
> > @@ -292,7 +292,7 @@ extern int unregister_pm_notifier(struct
> >  /* drivers/base/power/wakeup.c */
> >  extern bool events_check_enabled;
> >  
> > -extern bool pm_check_wakeup_events(void);
> > +extern bool pm_wakeup_pending(void);
> >  extern bool pm_get_wakeup_count(unsigned int *count);
> >  extern bool pm_save_wakeup_count(unsigned int count);
> >  #else /* !CONFIG_PM_SLEEP */
> > @@ -309,7 +309,7 @@ static inline int unregister_pm_notifier
> >  
> >  #define pm_notifier(fn, pri)	do { (void)(fn); } while (0)
> >  
> > -static inline bool pm_check_wakeup_events(void) { return true; }
> > +static inline bool pm_wakeup_pending(void) { return true; }
> 
> Shouldn't this return false?

Yes, it should, thanks!

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/