| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1291324103-7054-3-git-send-email-gregkh@suse.de> Date: Thu, 2 Dec 2010 13:08:20 -0800 From: Greg Kroah-Hartman <gregkh@...e.de> To: linux-kernel@...r.kernel.org Cc: Jiri Slaby <jslaby@...e.cz>, Alan Cox <alan@...ux.intel.com>, Andrew Hendry <andrew.hendry@...il.com>, linux-x25@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de> Subject: [PATCH 3/6] NET: wan/x25, fix ldisc->open retval From: Jiri Slaby <jslaby@...e.cz> We should never return positive values from ldisc->open, tty layer doesn't (and never did) expect that. If we do that, weird things like warnings in tty_ldisc_close happen. Not sure if dev->base_addr is used somehow now. Signed-off-by: Jiri Slaby <jslaby@...e.cz> Cc: Alan Cox <alan@...ux.intel.com> Cc: Andrew Hendry <andrew.hendry@...il.com> Cc: linux-x25@...r.kernel.org Tested-by: Sergey Lapin <slapin@...fans.org> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de> --- drivers/net/wan/x25_asy.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c index d81ad83..66cda25 100644 --- a/drivers/net/wan/x25_asy.c +++ b/drivers/net/wan/x25_asy.c @@ -582,7 +582,7 @@ static int x25_asy_open_tty(struct tty_struct *tty) if (err) return err; /* Done. We have linked the TTY line to a channel. */ - return sl->dev->base_addr; + return 0; } -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists