linux-kernel - Re: [PATCH] Bug in scripts/package/mkspec?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinK9dKnSZdkH57dZNMysg0uVu7DfNtmmZdG8HZD@mail.gmail.com>
Date:	Thu, 2 Dec 2010 16:15:20 -0500
From:	Patrick LeBoutillier <patrick.leboutillier@...il.com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bug in scripts/package/mkspec?

Hi Michal,

Sorry for the bad patch. Here is basically what I do:

$ make menuconfig
$ make rpm
...
Wrote: /root/rpmbuild/RPMS/x86_64/kernel-2.6.36.1-1.x86_64.rpm
...
$ make menuconfig # tweak some configs
$ make rpm
...
Wrote: /root/rpmbuild/RPMS/x86_64/kernel-2.6.36.1-1.x86_64.rpm
...

My expectation (and perhaps it is incorrect) is that subsequent "make
rpm"s on the same build tree
yield rpms with increasing release numbers (2.6.36.1-1, 2.6.36.1-2,
...). Is this how it's supposed
to work?

If that's the case, I think there needs to be a dependency between the
kernel.spec file and the .version file.
I think my (bad) patch worked once because it touched the mkspec
script, thereby causing the kernel.spec
file to be regenerated at the next "make rpm".

Patrick

On Thu, Dec 2, 2010 at 10:25 AM, Michal Marek <mmarek@...e.cz> wrote:
> On 18.11.2010 19:13, Patrick LeBoutillier wrote:
>> Hi all,
>>
>> I've been building RPMs for the Linux kernel for a while now and only
>> recently noticed that the RPM Release field is always set to 1.
>> After a bit of searching I found the offending line in
>> scripts/package/mkspec. Here is a patch that worked for me, but
>> perhaps this
>> could be fixed in better way by someone knowledgeable of the kernel
>> build process...:
>>
>>
>> --- ./mkspec.next       2010-11-18 13:08:56.000000000 -0500
>> +++ mkspec      2010-11-18 13:10:13.000000000 -0500
>> @@ -29,7 +29,7 @@
>>  echo "Version: $__KERNELRELEASE"
>>  # we need to determine the NEXT version number so that uname and
>>  # rpm -q will agree
>> -echo "Release: `. $srctree/scripts/mkversion`"
>> +echo "Release: `cd $srctree && ./scripts/mkversion`"
>
> This doesn't look correct to me, the script reads the .version file
> which is in the build directory, not in the source dir. Can you post a
> step-by-step reproducer for your bug?
>
> Thanks,
> Michal
>

-- 
=====================
Patrick LeBoutillier
Rosemère, Québec, Canada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/