linux-kernel - Re: [RFC] perf: Prevent potential null dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101202224816.GB6471@lenovo>
Date:	Fri, 3 Dec 2010 01:48:16 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [RFC] perf: Prevent potential null dereference

On Thu, Dec 02, 2010 at 08:46:10PM -0200, Arnaldo Carvalho de Melo wrote:
...
> > > It seems exit right here is more convenient than passing error
> > > handling level up (which would have to exit anyway), thought
> > > if handling it "upper" is preferred -- just say a word.
> > > 
> > 
> > Good.
> > 
> > As a nit, not that it matters that much because we are very close to the starting code
> > anyway, but it would be better to propagate the error to the callers.
> 
> I'm of the opinion that main() should be where exit() is allowed, and
> even there... return would be better. 8-)
> 
> - Arnaldo
> 

ok, i'll update tomorrow (almost off).

  Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/