linux-kernel - [GIT PULL?] RBD sysfs interface snafu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1012011350030.6260@cobra.newdream.net>
Date:	Wed, 1 Dec 2010 16:15:35 -0800 (PST)
From:	Sage Weil <sage@...dream.net>
To:	torvalds@...ux-foundation.org
cc:	linux-kernel@...r.kernel.org, ceph-devel@...r.kernel.org,
	greg@...ah.com
Subject: [GIT PULL?] RBD sysfs interface snafu

Hi Linus,

The sysfs interface for RBD (rados block device, merged in 2.6.37-rc1) was 
based on that of osdblk.  After seeing the SCST sysfs thread, though, I 
realized that was a poor example and that the existing RBD sysfs interface 
was bad news (multiple lines/items per file, incorrectly placed in 
/sys/class, etc.).  The sysfs portion of RBD really should have been 
explicitly reviewed by Greg KH beforehand--that was my fault for not 
involving him sooner.

We've fixed the interface, and now have an Acked-by from Greg, but it's 
pretty late in the cycle.  You could

 1- pull in the updated interface (changelog/diffstat below) from

  git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git rbd-sysfs

 2- make RBD depend on CONFIG_BROKEN (Greg's suggestion)
 3- drop RBD altogether and pull it again for .38

I don't think keeping the current interface for .37 is an option.  I 
obviously prefer #1 (we're still in CONFIG_EXPERIMENTAL territory here), 
but it's clearly your call.

Thanks!
sage

---

Yehuda Sadeh (1):
      rbd: replace the rbd sysfs interface

 Documentation/ABI/testing/sysfs-bus-rbd |   83 ++++
 drivers/block/rbd.c                     |  748 +++++++++++++++++++------------
 2 files changed, 554 insertions(+), 277 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-rbd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/