linux-kernel - Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=YUYuxQE8pDZrN5-PJq1Q3jw7cP2yZKCXNAvPP@mail.gmail.com>
Date:	Wed, 1 Dec 2010 20:10:00 -0600
From:	"Kanigeri, Hari" <h-kanigeri2@...com>
To:	"Varadarajan, Charulatha" <charu@...com>
Cc:	David Sin <davidsin@...com>, Greg KH <greg@...ah.com>,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, Lajos Molnar <molnar@...com>
Subject: Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

On Wed, Dec 1, 2010 at 12:04 AM, Varadarajan, Charulatha <charu@...com> wrote:
> David,

>
>> +               if (!oh)
>> +                       goto error;
>> +
>> +               data->base = oh->_mpu_rt_va;
>
> not required. Make use of platform_get APIs in probe to extract the
> base, dma and irq info using pdev.

Not sure about using platform_get APIs. I think one has to use
omap_hwmod_get_mpu_rt_va to get the address, which internally returns
oh-<_mpu_rt_va.
omap_hwmod_get_mpu_rt_va was added so that the individual drivers can
avoid doing the ioremap.
check the discussion regarding this.
http://www.spinics.net/lists/linux-omap/msg33048.html


Thank you,
Best regards,
Hari Kanigeri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/