linux-kernel - Re: [PATCH v3 2/3] Call the filesystem back whenever a page is removed from the page cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1291262016.6609.115.camel@heimdal.trondhjem.org>
Date:	Wed, 01 Dec 2010 22:53:36 -0500
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Nick Bowler <nbowler@...iptictech.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-nfs@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nick Piggin <npiggin@...nel.dk>,
	Rik van Riel <riel@...hat.com>,
	Christoph Hellwig <hch@....de>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v3 2/3] Call the filesystem back whenever a page is
 removed from the page cache

On Wed, 2010-12-01 at 19:34 -0800, Hugh Dickins wrote:
> On Wed, 1 Dec 2010, Trond Myklebust wrote:
> > 
> > --- a/mm/truncate.c
> > +++ b/mm/truncate.c
> > @@ -108,6 +108,10 @@ truncate_complete_page(struct address_space *mapping, struct page *page)
> >  	clear_page_mlock(page);
> >  	remove_from_page_cache(page);
> >  	ClearPageMappedToDisk(page);
> > +
> > +	if (mapping->a_ops->freepage)
> > +		mapping->a_ops->freepage(page);
> > +
> >  	page_cache_release(page);	/* pagecache ref */
> >  	return 0;
> >  }
> 
> I think Linus recommended that one be done in remove_from_page_cache()
> to catch all instances: did that get overruled later for some reason?

I'm fine with doing that as long as everyone is happy that there is no
chance of races. I was a bit nervous given the discussion that ensued
from the vmscan case.

> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -454,6 +454,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page)
> >  	BUG_ON(!PageLocked(page));
> >  	BUG_ON(mapping != page_mapping(page));
> >  
> > +	preempt_disable();
> >  	spin_lock_irq(&mapping->tree_lock);
> >  	/*
> >  	 * The non racy check for a busy page.
> > @@ -492,10 +493,19 @@ static int __remove_mapping(struct address_space *mapping, struct page *page)
> >  		swp_entry_t swap = { .val = page_private(page) };
> >  		__delete_from_swap_cache(page);
> >  		spin_unlock_irq(&mapping->tree_lock);
> > +		preempt_enable();
> >  		swapcache_free(swap, page);
> >  	} else {
> > +		void (*freepage)(struct page *);
> > +
> > +		freepage = mapping->a_ops->freepage;
> > +
> >  		__remove_from_page_cache(page);
> >  		spin_unlock_irq(&mapping->tree_lock);
> > +		if (freepage != NULL)
> > +			freepage(page);
> > +		preempt_enable();
> > +
> >  		mem_cgroup_uncharge_cache_page(page);
> >  	}
> >  
> > @@ -503,6 +513,7 @@ static int __remove_mapping(struct address_space *mapping, struct page *page)
> >  
> >  cannot_free:
> >  	spin_unlock_irq(&mapping->tree_lock);
> > +	preempt_enable();
> >  	return 0;
> >  }
> 
> I took his "stop_machine()" explanation ("an idle period for everything.
> And just a preemption reschedule isn't enough for that") to imply that
> there's no need for your preempt_disable/preempt_enable there: they
> don't add anything to the module unload case, and they don't help the
> spin_unlock_irq issue (and you're already being rightly careful to note
> freepage in advance).
> 
> But maybe I misunderstood.

Again, I was being cautious (I freely admit to not having studied
stop_machine()). If nobody disagrees with your interpretation, then I'm
very happy to drop the preempt disable/enable crud.

Cheers
  Trond
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/