lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 03 Dec 2010 12:01:26 +0000 From: Liam Girdwood <lrg@...mlogic.co.uk> To: Axel Lin <axel.lin@...il.com> Cc: linux-kernel <linux-kernel@...r.kernel.org>, Arnaud Patard <arnaud.patard@...-net.org>, Mark Brown <broonie@...nsource.wolfsonmicro.com>, alsa-devel@...a-project.org Subject: Re: [PATCH] ASoC: Fix inconsistent meaning of default case while checking alc5623->id On Fri, 2010-12-03 at 17:25 +0800, Axel Lin wrote: > In alc5623_i2c_probe(), > the default case for checking alc5623->id behaves the same as case 0x23. > However, In alc5623_probe() the default case for checking alc5623->id > becomes to be the same as case 0x21. > This makes the meaning of default case inconsistent. > > Since we have checked codec id in alc5623_i2c_probe() by comparing > vid2 with id->driver_data, it is not possible to run into the default case now. > > In case we may add more supported devices to alc5623_i2c_table in the future, > this patch changes the default case return -EINVAL to let people know that > they should not run into this case. They should also add a new case accordingly > for the new id. > > Signed-off-by: Axel Lin <axel.lin@...il.com> Acked-by: Liam Girdwood <lrg@...mlogic.co.uk> -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists