linux-kernel - RE: [PATCH v3 2/3]set timeout control reg for such SDHCI host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5D8008F58939784290FAB48F54975198320B3E41F7@shsmsx502.ccr.corp.intel.com>
Date:	Fri, 3 Dec 2010 10:38:59 +0800
From:	"Dong, Chuanxiao" <chuanxiao.dong@...el.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
CC:	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"cjb@...top.org" <cjb@...top.org>,
	"arjan@...ux.intel.com" <arjan@...ux.intel.com>,
	"alan@...ux.intel.com" <alan@...ux.intel.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"adrian.hunter@...ia.com" <adrian.hunter@...ia.com>,
	"prakity@...vell.com" <prakity@...vell.com>
Subject: RE: [PATCH v3 2/3]set timeout control reg for such SDHCI host

 > 
> On Thu, Dec 02, 2010 at 07:26:13PM +0800, Chuanxiao Dong wrote:
> 
> > +	if (host->quirks & SDHCI_QUIRK_FORCE_ERASE_SINGLE) {
> > +		/* Set the timeout to be the maximum value */
> > +		if (cmd->erase_timeout)
> > +			sdhci_writeb(host, 0xE, SDHCI_TIMEOUT_CONTROL);
> > +	}
> > +
> >  	sdhci_writew(host, SDHCI_MAKE_CMD(cmd->opcode, flags),
> > SDHCI_COMMAND);
> 
> Hmm, this looks like another argument for Philip's idea to always use the maximum
> timeout value and skip the quirks related to it?

Yes, if always using the maximum timeout value is OK for other command, the patch2 can be removed I think.
The new added quirk in the serials patches is used to set the limitation of request queue, not only just to set the timeout control reg.
Even the timeout value was set to be 0xE (the maximum value), erasing too many sectors can still be failed since the timeout time was still not longer enough.
So the count of erased sectors passed down by request queue should be reduced by using this quirk.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/