linux-kernel - Re: [PATCH] intel_mid_dma: Fix section mismatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Dec 2010 17:13:10 -0800
From:	Dan Williams <dan.j.williams@...el.com>
To:	Major_Lee@...tron.com
Cc:	linux-kernel@...r.kernel.org, vinod.koul@...el.com
Subject: Re: [PATCH] intel_mid_dma: Fix section mismatch warnings

On Tue, Nov 30, 2010 at 12:24 AM,  <Major_Lee@...tron.com> wrote:
> Fix the following section mismatch warnings.

Actually no, this patch does not fix the warnings, it hides them by
undoing the annotation.

Take a closer look at the warning message:

>
> WARNING: drivers/built-in.o(.data+0xfa10): Section mismatch in reference
> from the variable intel_mid_dma_pci to the function
> .devinit.text:intel_mid_dma_probe()
> The variable intel_mid_dma_pci references the function __devinit
> intel_mid_dma_probe() If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the
> variable:
> *driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one,
> *_console,

Let me highlight the relevant suggestion:

> or name the variable:
> *driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one,
> *_console,

...nowhere does it say delete the __devinit annotation.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/