linux-kernel - Re: [PATCH v4 3/3] KVM: MMU: retry #PF for softmmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CFCB150.40202@redhat.com>
Date:	Mon, 06 Dec 2010 11:48:00 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
CC:	Marcelo Tosatti <mtosatti@...hat.com>,
	Gleb Natapov <gleb@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v4 3/3] KVM: MMU: retry #PF for softmmu

On 12/02/2010 11:46 AM, Xiao Guangrong wrote:
> Retry #PF for softmmu only when the current vcpu has the same cr3 as the time
> when #PF occurs
>
> Changelog:
>    Just compare cr3 value since It's harmless to instantiate an spte for an
>    unused translation from Marcelo's comment
>

It's not harmless.  We could be in a different process, so we have to 
re-fetch the gpte.  Or we could have switched from one nested guest to 
another.

>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index c6bb449..3f0d9a0 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -2607,9 +2607,11 @@ static int nonpaging_page_fault(struct kvm_vcpu *vcpu, gva_t gva,
>   static int kvm_arch_setup_async_pf(struct kvm_vcpu *vcpu, gva_t gva, gfn_t gfn)
>   {
>   	struct kvm_arch_async_pf arch;
> +
>   	arch.token = (vcpu->arch.apf.id++<<  12) | vcpu->vcpu_id;
>   	arch.gfn = gfn;
>   	arch.direct_map = vcpu->arch.mmu.direct_map;
> +	arch.cr3 = vcpu->arch.mmu.get_cr3(vcpu);
>
>   	return kvm_setup_async_pf(vcpu, gva, gfn,&arch);
>   }
> diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h
> index 23275d0..437e11a 100644
> --- a/arch/x86/kvm/paging_tmpl.h
> +++ b/arch/x86/kvm/paging_tmpl.h
> @@ -116,7 +116,7 @@ static unsigned FNAME(gpte_access)(struct kvm_vcpu *vcpu, pt_element_t gpte)
>    */
>   static int FNAME(walk_addr_generic)(struct guest_walker *walker,
>   				    struct kvm_vcpu *vcpu, struct kvm_mmu *mmu,
> -				    gva_t addr, u32 access)
> +				    gva_t addr, u32 access, bool prefault)
>   {
>   	pt_element_t pte;
>   	gfn_t table_gfn;
> @@ -194,6 +194,13 @@ walk:
>   #endif
>
>   		if (!eperm&&  !rsvd_fault&&  !(pte&  PT_ACCESSED_MASK)) {
> +			/*
> +			 * Don't set gpte accessed bit if it's on
> +			 * speculative path.
> +			 */
> +			if (prefault)
> +				goto error;

It's actually legal to set the accessed bit on speculative access.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/