linux-kernel - Re: [PATCH v2 1/4]enable background operations for supported eMMC card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Dec 2010 13:28:49 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Chuanxiao Dong <chuanxiao.dong@...el.com>
Cc:	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	cjb@...top.org, akpm@...ux-foundation.org, arjan@...ux.intel.com,
	alan@...ux.intel.com, kmpark@...radead.org
Subject: Re: [PATCH v2 1/4]enable background operations for supported eMMC card

On Friday 03 December 2010, Chuanxiao Dong wrote:
> From 984adc755cf2f7966a89e510a50f085e314fe347 Mon Sep 17 00:00:00 2001
> From: Chuanxiao Dong <chuanxiao.dong@...el.com>
> Date: Mon, 22 Nov 2010 16:31:12 +0800
> Subject: [PATCH 1/4] mmc: Enabled background operations feature if eMMC card supports

These headers don't belong into a submission. If you use git-send-email,
they get cut off automatically, otherwise just remove them as you paste
the patch into your mail client.

> Background operations is a new feature defined in eMMC4.41 standard.
> Since this feature is opertional for eMMC card, so driver only enable

s/opertional/optional/

> @@ -54,6 +54,8 @@ struct mmc_ext_csd {
>  	unsigned int		sec_trim_mult;	/* Secure trim multiplier  */
>  	unsigned int		sec_erase_mult;	/* Secure erase multiplier */
>  	unsigned int		trim_timeout;		/* In milliseconds */
> +	unsigned int		bkops:1; /* background support bit */
> +	unsigned int		bkops_en:1; /* background enable bit */
>  };

Bit fields are not encouraged for kernel internal data structures,
just use "bool" variables here.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/