linux-kernel - RE: [PATCH] dma : EG20T PCH: Fix miss-setting DMA descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <FC2FB65B4D919844ADE4BE3C2BB739AD331B2807@shsmsx501.ccr.corp.intel.com>
Date:	Mon, 6 Dec 2010 20:58:28 +0800
From:	"Wang, Yong Y" <yong.y.wang@...el.com>
To:	"Williams, Dan J" <dan.j.williams@...el.com>,
	Tomoya MORINAGA <tomoya-linux@....okisemi.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Ewe, Kok Howg" <kok.howg.ewe@...el.com>,
	"Wang, Qi" <qi.wang@...el.com>,
	"Clark, Joel" <joel.clark@...el.com>,
	"Foster, Margie" <margie.foster@...el.com>,
	"Khor, Andrew Chih Howe" <andrew.chih.howe.khor@...el.com>
Subject: RE: [PATCH] dma : EG20T PCH: Fix miss-setting DMA descriptor

> > diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> > index 92b6790..a3d54c0 100644
> > --- a/drivers/dma/pch_dma.c
> > +++ b/drivers/dma/pch_dma.c
> [..]
> > @@ -273,10 +268,16 @@ static void pdc_dostart(struct pch_dma_chan
> *pd_chan, struct pch_dma_desc* desc)
> >        dev_dbg(chan2dev(&pd_chan->chan), "chan %d -> next: %x\n",
> >                pd_chan->chan.chan_id, desc->regs.next);
> >
> > -       if (list_empty(&desc->tx_list))
> > +       if (list_empty(&desc->tx_list)) {
> > +               channel_writel(pd_chan, DEV_ADDR,
> desc->regs.dev_addr);
> > +               channel_writel(pd_chan, MEM_ADDR,
> desc->regs.mem_addr);
> > +               channel_writel(pd_chan, SIZE, desc->regs.size);
> > +               channel_writel(pd_chan, NEXT, desc->regs.next);
> >                pdc_set_mode(&pd_chan->chan,
> DMA_CTL0_ONESHOT);
> > -       else
> > +       } else {
> > +               channel_writel(pd_chan, NEXT,
> virt_to_phys(&desc->regs));
> 
> There is a reason for the following comment for virt_to_phys():
> 
> /*      This function does not give bus mappings for DMA transfers. In
>  *      almost all conceivable cases a device driver should not be using
>  *      this function
>  */
> 
> ...in this case this wants to be:
> 
>      channel_write(pd_chan, NEXT, desc->txd.phys);
> 
> I'll let Yong comment on the correctness of the rest.
> 

Hi Dan,

Apart from the issue you pointed out, the patch looks good to me. If it is convenient for you, please help make the change and merge this patch. Otherwise, please let Tomoya know that you want him to send an updated patch. Thanks!

Acked-by: Yong Wang <youg.y.wang@...el.com>

-Yong

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/