linux-kernel - Re: [PATCH v4 3/3] KVM: MMU: retry #PF for softmmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CFCE270.1080500@redhat.com>
Date:	Mon, 06 Dec 2010 15:17:36 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
CC:	Marcelo Tosatti <mtosatti@...hat.com>,
	Gleb Natapov <gleb@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v4 3/3] KVM: MMU: retry #PF for softmmu

On 12/06/2010 12:22 PM, Xiao Guangrong wrote:
> Hi Avi,
>
> On 12/06/2010 05:48 PM, Avi Kivity wrote:
> >  On 12/02/2010 11:46 AM, Xiao Guangrong wrote:
> >>  Retry #PF for softmmu only when the current vcpu has the same cr3 as
> >>  the time
> >>  when #PF occurs
> >>
> >>  Changelog:
> >>     Just compare cr3 value since It's harmless to instantiate an spte
> >>  for an
> >>     unused translation from Marcelo's comment
> >>
> >
> >  It's not harmless.  We could be in a different process, so we have to
> >  re-fetch the gpte.  Or we could have switched from one nested guest to
> >  another.
> >
>
> But it does this in this patch: re-walk guest page table and fixes guest's
> shadow page (not use any info when apf is occurred)

Right.  Please resend without the walk_addr() changes.  While they're 
correct, I'd like to keep that part simpler.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/