linux-kernel - Re: [linux-pm] [PATCH] PM / Hibernate: Restore old swap signature to avoid user space breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101206132613.GB9421@nb.net.home>
Date:	Mon, 6 Dec 2010 14:26:13 +0100
From:	Karel Zak <kzak@...hat.com>
To:	Bojan Smojver <bojan@...ursive.com>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux-pm mailing list <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Dr. David Alan Gilbert" <linux@...blig.org>
Subject: Re: [linux-pm] [PATCH] PM / Hibernate: Restore old swap signature
	to avoid user space breakage

On Mon, Dec 06, 2010 at 10:36:55AM +1100, Bojan Smojver wrote:
> On Sun, 2010-12-05 at 23:24 +0100, Rafael J. Wysocki wrote:
> > Commit 3624eb0 (PM / Hibernate: Modify signature used to mark swap)
> > modified hibernate signature used to mark swap partitions containing
> > hibernation images, but that turns out to have caused problems in
> > libblkid on recent Ubuntu.  Restore the old signature to avoid those
> > problems. 
> 
> Don't quite understand this change (sorry, probably just being obtuse).

 I too.

> The signature was changed to make sure older kernels don't handle
> compressed images by accident, right? If so, this would seem like a bad
> idea, because this is what can actually happen now.
> 
> Shouldn't user space learn how to handle both signatures instead?

 The upstream libblkid has been updated, there is not a problem to
 support more signatures.

    Karel

-- 
 Karel Zak  <kzak@...hat.com>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/