linux-kernel - Re: [PATCH] arm: ecard: Fix compilation warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101206140506.GE31777@n2100.arm.linux.org.uk>
Date:	Mon, 6 Dec 2010 14:05:06 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Marek Belisko <marek.belisko@...n-nandra.com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: ecard: Fix compilation warning.

On Mon, Dec 06, 2010 at 03:04:03PM +0100, Marek Belisko wrote:
> Fix following compilation warning:
> arch/arm/kernel/ecard.c:1066: warning: ignoring return value of
> 'device_register', declared with attribute warn_unused_result
> 
> Signed-off-by: Marek Belisko <marek.belisko@...n-nandra.com>
> ---
>  arch/arm/kernel/ecard.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
> index eed2f79..da882b1 100644
> --- a/arch/arm/kernel/ecard.c
> +++ b/arch/arm/kernel/ecard.c
> @@ -1063,8 +1063,10 @@ ecard_probe(int slot, card_type_t type)
>  	*ecp = ec;
>  	slot_to_expcard[slot] = ec;
>  
> -	device_register(&ec->dev);
> -
> +	rc = device_register(&ec->dev);
> +	if (rc)
> +		goto nodev;
> +
>  	return 0;

No.  It is important that cards which are actually there remain present
even if device_register fails.  In other words, we _really_ don't care
what device_register() returns.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/