lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <s5h1v5vue8j.wl%tiwai@suse.de>
Date:	Mon, 06 Dec 2010 16:12:44 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Jeffrin Jose <ahiliation@...oo.co.in>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: sound: Fixed line limit issue in sound/ac97_bus.c

At Mon, 6 Dec 2010 20:37:24 +0530,
Jeffrin Jose wrote:
> 
> hello.
> a small patch for a format issue is attached with this
> mail.

Thanks for the patch.

I applied it now, but had to fix a few things manually:
 - A blank line is necessary between the patch subject and the
   changelog text; otherwise git-am will be confused
 - You don't have to indent the change text
 - Align the closing comment "*/"


Takashi

> -- 
> software engineer.
> department of computer science
> rajagiri school of engineering and technology.
> [2 0001-sound-Fixed-line-limit-issue-in-sound-ac97_bus.c.patch <text/x-diff; us-ascii (7bit)>]
> >From a2c2867876c246420a199a0fb4c36ad2965a42cc Mon Sep 17 00:00:00 2001
> From: Jeffrin Jose <ahiliation@...oo.co.in>
> Date: Mon, 6 Dec 2010 19:27:53 +0530
> Subject: [PATCH] sound: Fixed line limit issue in sound/ac97_bus.c
>  This is a patch to the sound/ac97_bus.c file that fixes up a 80 character
>  line limit issue found by the checkpatch.pl tool.
>  Signed-off-by: Jeffrin Jose <ahiliation@...oo.co.in>
> 
> ---
>  sound/ac97_bus.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/ac97_bus.c b/sound/ac97_bus.c
> index a351dd0..c93251a 100644
> --- a/sound/ac97_bus.c
> +++ b/sound/ac97_bus.c
> @@ -19,9 +19,9 @@
>  
>  /*
>   * Let drivers decide whether they want to support given codec from their
> - * probe method.  Drivers have direct access to the struct snd_ac97 structure and may
> - * decide based on the id field amongst other things.
> - */
> + * probe method. Drivers have direct access to the struct snd_ac97
> + * structure and may  decide based on the id field amongst other things.
> +*/
>  static int ac97_bus_match(struct device *dev, struct device_driver *drv)
>  {
>  	return 1;
> -- 
> 1.7.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ