linux-kernel - Re: [PATCH] add additional audit info (read/write length & rng name) for RNG devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1291649535.3065.2088.camel@calx>
Date:	Mon, 06 Dec 2010 09:32:15 -0600
From:	Matt Mackall <mpm@...enic.com>
To:	Neil Horman <nhorman@...driver.com>
Cc:	linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
	Eric Paris <eparis@...hat.com>
Subject: Re: [PATCH] add additional audit info (read/write length & rng
 name) for RNG devices

On Mon, 2010-12-06 at 10:21 -0500, Neil Horman wrote:
> Add /dev/[u]random auditing
> 
> Patch to enhance auditing of user visible random number generators.  Allows us to
> determine how many bytes of random data were obtained on each read from an RNG
> device
> 
> Signed-off-by: Eric Paris <eparis@...hat.com>
> Signed-off-by: Neil Horman <nhorman@...driver.com>

The random.c parts looks fine to me.

Acked-by: Matt Mackall <mpm@...enic.com>

> +	context->aux = (void *)ax;

Redundant cast to void *?

-- 
Mathematics is the supreme nostalgia of our time.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/