[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20101206232159.GS8345@atomide.com>
Date: Mon, 6 Dec 2010 15:21:59 -0800
From: Tony Lindgren <tony@...mide.com>
To: David Sin <davidsin@...com>
Cc: Greg KH <greg@...ah.com>, Russell King <rmk@....linux.org.uk>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, Lajos Molnar <molnar@...com>
Subject: Re: [PATCH 7/9] TILER-DMM: Main TILER driver implementation
Hi,
* David Sin <davidsin@...com> [101206 14:09]:
> From: Lajos Molnar <molnar@...com>
>
> This patch contains the TILER driver and implementation of the TILER
> block manipulation and mapping functions.
>
> It also contains the makefile and config file for the TILER driver.
...
> +config TILER_GRANULARITY
> + int "Allocation granularity"
> + range 1 4096
> + default 128
...
> +config TILER_ALIGNMENT
> + int "Allocation alignment"
> + range 1 4096
> + default 4096
...
> +config TILER_CACHE_LIMIT
> + int "Memory limit to cache free pages in MBytes"
> + range 0 128
> + default 40
...
Do you really need these Kconfig options? To me it seems you
should pass these in platform_data.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists