[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4CFC2A05.7010509@phoenixsoftware.de>
Date: Mon, 06 Dec 2010 01:10:45 +0100
From: Tilman Schmidt <t.schmidt@...enixsoftware.de>
To: Alexey Dobriyan <adobriyan@...il.com>
CC: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 26/45] kstrtox: convert drivers/isdn/
I like the patch, but why not go all the way?
Am 05.12.2010 18:49 schrieb Alexey Dobriyan:
> @@ -566,10 +566,10 @@ void gigaset_handle_modem_response(struct cardstate *cs)
> case RT_ZCAU:
> event->parameter = -1;
> if (curarg + 1 < params) {
> - unsigned long type, value;
> + u8 type, value;
>
> - i = strict_strtoul(argv[curarg++], 16, &type);
> - j = strict_strtoul(argv[curarg++], 16, &value);
> + i = kstrtou8(argv[curarg++], 16, &type);
> + j = kstrtou8(argv[curarg++], 16, &value);
>
> if (i == 0 && type < 256 &&
> j == 0 && value < 256)
Once type and value are u8, the checks for < 256 are unnecessary.
> @@ -583,7 +583,7 @@ void gigaset_handle_modem_response(struct cardstate *cs)
> unsigned long res;
> int rc;
>
> - rc = strict_strtoul(argv[curarg++], 10, &res);
> + rc = kstrtoul(argv[curarg++], 10, &res);
> if (rc == 0)
> event->parameter = res;
> }
The new kstrtoul() promises not to touch the result field in the event
of a conversion error, so &event->parameter can be passed directly to
it, getting rid of the variables rc and res and the if statement.
Thanks,
Tilman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists