linux-kernel - Re: acpi_button: random oops on boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201012061626.45962.bjorn.helgaas@hp.com>
Date:	Mon, 6 Dec 2010 16:26:45 -0700
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Tobias Karnat <tobias.karnat@...glemail.com>
Cc:	linux-acpi@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	richard.coe@....ge.com, jslaby@...ell.com
Subject: Re: acpi_button: random oops on boot

On Monday, December 06, 2010 04:01:43 pm Tobias Karnat wrote:
> Am Montag, den 06.12.2010, 09:28 -0700 schrieb Bjorn Helgaas:
> > On Saturday, December 04, 2010 08:49:12 am Tobias Karnat wrote:
> > > Applying the patch from the thread, makes the problem occurring less
> > > often and dmesg shows acpi-button loads for me on hid PNP0C0C and
> > > LNXPWRBN.
> > > 
> > > Maybe commit e2fb9754d27513918a4936e8cbaad50ff56cfd3d
> > > ACPI: button: remove unnecessary null pointer checks
> > > has unmasked an underlying problem?
> > 
> > The oopses from the bugzilla are not the sort I would expect from
> > a null pointer dereference, but since it's fairly reproducible for
> > you, it might be worth reverting e2fb9754d27 to see whether it makes
> > any difference.
> 
> I was not able to revert it.
> But it would only mask the problem anyway...

Right, but now the granularity is "remove the acpi_button driver
completely."  If we can identify a specific statement inside
acpi_button that makes a difference, that might help.

> I have now reverted bf04a77227db76f163bc2355ef4e176794987be2
> ACPI: button: cache hid/name/class pointers and build acpi_button
> as a module but this makes no difference.
> 
> > Does Rich's script from https://bugzilla.novell.com/show_bug.cgi?id=647029#c30
> > help you reproduce the problem?
> 
> No, it only crashes on boot (without the printk patch).
> If it happens the machine is completely dead, SysRq does not work.
> 
> However it is definitely the acpi_button module, because removing it
> also fixes this.

If it crashes on boot (not when loading an acpi_button module),
you must be building acpi_button into the static kernel.

The acpi_button driver has a fairly complicated add() method.
In the absence of a better idea, I might just comment out blocks
of it and try to isolate the problem.  For example, take out
all the input stuff, take out the wakeup GPE stuff, take out
the type/name setup, etc.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/