linux-kernel - Re: [RFC][PATCH] input: Introduce device information ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=Av1N2URqpgrAUCreFoJXb6ZtEkkgp_Jo4BgRw@mail.gmail.com>
Date:	Tue, 7 Dec 2010 13:52:28 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Henrik Rydberg <rydberg@...omail.se>,
	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ping Cheng <pingc@...om.com>,
	Chris Bagwell <chris@...bagwell.com>
Subject: Re: [RFC][PATCH] input: Introduce device information ioctl

On Tue, Dec 7, 2010 at 13:44, Arnd Bergmann <arnd@...db.de> wrote:
> On Tuesday 07 December 2010, Kay Sievers wrote:
>> On Tue, Dec 7, 2010 at 11:56, Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:
>> > On Tue, Dec 07, 2010 at 11:48:28AM +0100, Kay Sievers wrote:
>>
>> >> Please don't add new ioctls which are not extensible. The ioctl should
>> >> carry the length or the version of the structure it asks for, so it
>> >> can be extended in the future.
>> >
>> > Size of ioctl data is encoded in ioctl, it can be extended easily. For
>> > examples take a look at how EVIOCGKEYCODE and EVIOCGSKEYCODE are handled
>> > in recent kernels.
>>
>> Oh, how does that work? With the ioctl call, userspace has to supply
>> the size it expects to be returned from the kernel. How does the
>> kernel otherwise know how much it is allowed to copy to the user?
>
> The ioctl command number itself is calculated from the size of the
> data that gets passed:
>
> #define EVIOCGDEVINFO          _IOR('E', 0x09, struct input_devinfo)
>
> If struct input_devinfo ever changes (which it can, but should not),
> the command changes as well.

So unlike statet, it's not extensible, and this struct and this ioctl
can never change?

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/