linux-kernel - Re: [tip:x86/platform] x86: Unify current 3 similar ways of saving IRQ info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Dec 2010 16:56:21 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Feng Tang <feng.tang@...el.com>
cc:	Yinghai Lu <yinghai@...nel.org>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"alan@...ux.intel.com" <alan@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Brown, Len" <len.brown@...el.com>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/platform] x86: Unify current 3 similar ways of saving
 IRQ info

On Tue, 7 Dec 2010, Feng Tang wrote:
> On Tue, 7 Dec 2010 01:50:36 +0800
> Yinghai Lu <yinghai@...nel.org> wrote:
>  
> +static void assign_to_mp_irq(struct mpc_intsrc *m,
> +				    struct mpc_intsrc *mp_irq)
> +{
> +	mp_irq->dstapic = m->dstapic;
> +	mp_irq->type = m->type;
> +	mp_irq->irqtype = m->irqtype;
> +	mp_irq->irqflag = m->irqflag;
> +	mp_irq->srcbus = m->srcbus;
> +	mp_irq->srcbusirq = m->srcbusirq;
> +	mp_irq->dstirq = m->dstirq;

  Can we please use the mrst version with memcpy ?

> +}
> +
> +static int mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq,
> +					struct mpc_intsrc *m)
> +{
> +	if (mp_irq->dstapic != m->dstapic)
> +		return 1;
> +	if (mp_irq->type != m->type)
> +		return 2;
> +	if (mp_irq->irqtype != m->irqtype)
> +		return 3;
> +	if (mp_irq->irqflag != m->irqflag)
> +		return 4;
> +	if (mp_irq->srcbus != m->srcbus)
> +		return 5;
> +	if (mp_irq->srcbusirq != m->srcbusirq)
> +		return 6;
> +	if (mp_irq->dstirq != m->dstirq)
> +		return 7;
> +
> +	return 0;

  Same here. No caller is interested in the detailed return value.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/