linux-kernel - Re: [PATCH 1/3] [SCSI] dpt_i2o: fix compiler warning on dptids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1291737421.17668.5.camel@mulgrave.site>
Date:	Tue, 07 Dec 2010 09:57:01 -0600
From:	James Bottomley <James.Bottomley@...e.de>
To:	Namhyung Kim <namhyung@...il.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Adaptec OEM Raid Solutions <aacraid@...ptec.com>
Subject: Re: [PATCH 1/3] [SCSI] dpt_i2o: fix compiler warning on dptids

On Wed, 2010-12-08 at 00:31 +0900, Namhyung Kim wrote:
> Annotate dptids as '__used' to fix following warning:
> 
>   CC      drivers/scsi/dpt_i2o.o
> drivers/scsi/dpt_i2o.c:183: warning: ‘dptids’ defined but not used
> 
> Signed-off-by: Namhyung Kim <namhyung@...il.com>
> Cc: Adaptec OEM Raid Solutions <aacraid@...ptec.com>
> ---
>  drivers/scsi/dpt_i2o.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index cffcb10..b276077 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -180,7 +180,7 @@ static u8 adpt_read_blink_led(adpt_hba* host)
>   *============================================================================
>   */
>  
> -static struct pci_device_id dptids[] = {
> +static struct pci_device_id dptids[] __used = {
>  	{ PCI_DPT_VENDOR_ID, PCI_DPT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
>  	{ PCI_DPT_VENDOR_ID, PCI_DPT_RAPTOR_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
>  	{ 0, }

Um so this is definitely used in the MODULE_DEVICE_TABLE just below.

I deduce you have some type of config which causes that to be a nop
(say !CONFIG_MODULE)?  In which case, surely the correct fix is in
module.h?

James



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/