linux-kernel - Re: [linux-next] next-20101207: Better now, but modinfo ath5k

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101207155924.GC2700@tuxdriver.com>
Date:	Tue, 7 Dec 2010 10:59:24 -0500
From:	"John W. Linville" <linville@...driver.com>
To:	sedat.dilek@...il.com
Cc:	wireless <linux-wireless@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Nick Kossifidis <mickflemm@...il.com>,
	Bruno Randolf <br1@...fach.org>,
	ath5k-devel <ath5k-devel@...ema.h4ckr.net>
Subject: Re: [linux-next] next-20101207: Better now, but modinfo ath5k

On Tue, Dec 07, 2010 at 04:57:08PM +0100, Sedat Dilek wrote:
> On Tue, Dec 7, 2010 at 3:26 PM, John W. Linville <linville@...driver.com> wrote:
> > On Tue, Dec 07, 2010 at 12:24:14PM +0100, Sedat Dilek wrote:
> >
> >> I have already reported on linux-wireless (short: l-w) ML that after
> >> especially the merge of "AHB Bus support" patchset (see [2]) my ath5k
> >> was not working as expected in daily use (also modinfo).
> >>
> >> I am not sure if it is the driver but reverting the 9 commits in my
> >> local linux-next GIT seemed to "stabilize" a bit the Internet
> >> connection.
> >> The patchset from Nick (see below) definitely helped to stabilize ath5k.
> >
> > I imagine that these are the "9 commits" you mean:
> >
> >> git rev-list c30ae13..4cebb34
> > 4cebb34caa5122216a1e2451eae9e0fc47ec2589
> > a0b907ee2a71052fefdf6151764095f3f97b3275
> > c31b5c9c806b1fbdc9e98885d897664a0d482989
> > e7aecd327d80b2f156b54769013aaccb2a20645a
> > 8efa5d7d6ad307ae2d220def37ca89594062c40d
> > 4aa5d783c9e1c72e4950ff34f388077ccecac74a
> > e5b046d86fac609f636d127a38de94a175c7e83b
> > 132b1c3ee38ea6fa0501004fd0f19acb554e5a44
> > aeae4ac9090462ea38387dcdbac4f01b944af6a4
> >
> > Most of those look fairly harmless so long as you don't define
> > CONFIG_ATHEROS_AR231X.  Just to narrow things down...if you only revert
> > the first 8 (i.e. leave aeae4ac alone), do you still have problems?
> > Or does it still "stabilize"?
> >
> > That patch converts the driver to the generic DMA API.  It seems
> > OK at first glance, but I suspect it is the only one likely to be
> > effecting your situation.
> >
> > John
> > --
> > John W. Linville                Someday the world will need a hero, and you
> > linville@...driver.com                  might be all we have.  Be ready.
> >
> 
> Before jumping to another problem, I had a quick look into the
> appropriate Kconfig file, as you say I have not CONFIG_ATHEROS_AR231X
> set and that's why AHB support is not selected/built, instead
> 
>   CC [M]  drivers/net/wireless/ath/ath5k/pci.o
> 
> is built.
> 
> Unfortunately, I can't cleanly revert. Sorry, I can't help.

I don't quite understand -- you said you were reverting them before,
but now I ask you to revert one _less_ patch (i.e. the last one to
be reverted anyway) and you can't do it?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/