linux-kernel - Re: [tip:x86/platform] x86: Unify current 3 similar ways of saving IRQ info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1012072327000.2653@localhost6.localdomain6>
Date:	Tue, 7 Dec 2010 23:32:46 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Yinghai Lu <yinghai@...nel.org>
cc:	Feng Tang <feng.tang@...el.com>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"alan@...ux.intel.com" <alan@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Brown, Len" <len.brown@...el.com>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/platform] x86: Unify current 3 similar ways of saving
 IRQ info

On Tue, 7 Dec 2010, Yinghai Lu wrote:
> On 12/07/2010 07:56 AM, Thomas Gleixner wrote:
> > 
> >   Same here. No caller is interested in the detailed return value.
> > 
> 

> ok, after look at code and git log, i knew the reasons for those
> strange duplicated functions.
>
> Alexy changed
> 
>  /* MP IRQ source entries */
> -struct mpc_config_intsrc mp_irqs[MAX_IRQ_SOURCES];
> +struct mp_config_intsrc mp_irqs[MAX_IRQ_SOURCES];
> 
> to make it decouple that with mpstable definition. so mptable will
> have mpc_intsrc, and acpi etc will use mp_config_intsrc
>
> and he planed to add more member to mp_config_intsrc .... never happened.
> 
> then I added those functions with different parameters.
> 
> one year later JSR changed all back to mpc_instr...
> 
> so now have some duplicated functions....

> So yes, we should use simple versions in
> arch/x86/kernel/acpi/boot.c. ( assume functions mrst.c are copied
> from there)
>
> and should kill print_mp_irq_info or print_MP_intsrc_info...

Nice archaelogical detective work ! :)

So now I have Fengs patch plus Yinghais series which seem to go nicely
together, but I have the feeling that there is some stuff unresolved.

Yinghai, Feng: could you please work out the missing bits an pieces
(if any) and provide me a delta patch on top of the existing patches?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/