linux-kernel - [RFC PATCH 3/3] block: improve detail in I/O error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1291763802-8251-4-git-send-email-snitzer@redhat.com>
Date:	Tue,  7 Dec 2010 18:16:42 -0500
From:	Mike Snitzer <snitzer@...hat.com>
To:	Hannes Reinecke <hare@...e.de>
Cc:	k-ueda@...jp.nec.com, michaelc@...wisc.edu, tytso@....edu,
	sshtylyov@...sta.com, linux-scsi@...r.kernel.org,
	jaxboe@...ionio.com, jack@...e.cz, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, swhiteho@...hat.com,
	linux-raid@...r.kernel.org, linux-ide@...r.kernel.org,
	dm-devel@...hat.com, James.Bottomley@...e.de,
	konishi.ryusuke@....ntt.co.jp, j-nomura@...jp.nec.com,
	vst@...b.net, rwheeler@...hat.com, hch@....de,
	chris.mason@...cle.com, tj@...nel.org
Subject: [RFC PATCH 3/3] block: improve detail in I/O error messages

Classify severity of I/O errors for target and transport errors.

Signed-off-by: Mike Snitzer <snitzer@...hat.com>
---
 block/blk-core.c |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index 4ce953f..ab8c776 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2028,9 +2028,15 @@ bool blk_update_request(struct request *req, int error, unsigned int nr_bytes)
 
 	if (error && req->cmd_type == REQ_TYPE_FS &&
 	    !(req->cmd_flags & REQ_QUIET)) {
-		printk(KERN_ERR "end_request: I/O error, dev %s, sector %llu\n",
-				req->rq_disk ? req->rq_disk->disk_name : "?",
-				(unsigned long long)blk_rq_pos(req));
+		char *error_type = "I/O";
+
+		if (error == -ENOLINK)
+			error_type = "recoverable transport";
+		else if (error == -EREMOTEIO)
+			error_type = "critical target";
+		printk(KERN_ERR "end_request: %s error, dev %s, sector %llu\n",
+		       error_type, req->rq_disk ? req->rq_disk->disk_name : "?",
+		       (unsigned long long)blk_rq_pos(req));
 	}
 
 	blk_account_io_completion(req, nr_bytes);
-- 
1.7.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/