linux-kernel - Re: [PATCH] perf_event: fix error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=HGdGs++FKY6=icEs3FTwSggXTu42JQ+1MCxBc@mail.gmail.com>
Date:	Wed, 8 Dec 2010 09:51:59 +0800
From:	jovi zhang <bookjovi@...il.com>
To:	Thiago Farina <tfransosi@...il.com>
Cc:	a.p.zijlstra@...llo.nl, paulus@...ba.org, mingo@...e.hu,
	acme@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf_event: fix error handling path

On Mon, Dec 6, 2010 at 9:59 AM, jovi zhang <bookjovi@...il.com> wrote:
> On Sun, Dec 5, 2010 at 8:29 PM, Thiago Farina <tfransosi@...il.com> wrote:
>>
>> On Sat, Dec 4, 2010 at 1:19 AM,  <bookjovi@...il.com> wrote:
>> > fix error handling path
>> >
>> > Signed-off-by: Jovi Zhang <bookjovi@...il.com>
>> >  kernel/perf_event.c |    2 --
>> >  1 files changed, 0 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/kernel/perf_event.c b/kernel/perf_event.c
>> > index cb6c0d2..62f9e9d 100644
>> > --- a/kernel/perf_event.c
>> > +++ b/kernel/perf_event.c
>> > @@ -1918,8 +1918,6 @@ static int get_callchain_buffers(void)
>> >        }
>> >
>> >        err = alloc_callchain_buffers();
>> > -       if (err)
>> > -               release_callchain_buffers();
>>
>> Care to explain in the change log message? As I reader, is not clear
>> to me what is wrong with this.
>
> Sorry, the description should be as:
> fix error handling path. alloc_callchain_buffers() can return -ENOMEM,
> in this time callchain_cpus_entries maybe is NULL, It will oops if
> invoke release_callchain_buffers() when callchain_cpus_entries is
> NULL.
>
I hope my understanding is right, is it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/