linux-kernel - Re: [PATCH v1.5 5/5] keys: add new key-type encrypted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13657.1291805664@redhat.com>
Date:	Wed, 08 Dec 2010 10:54:24 +0000
From:	David Howells <dhowells@...hat.com>
To:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, keyrings@...ux-nfs.org,
	linux-crypto@...r.kernel.org,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	James Morris <jmorris@...ei.org>,
	David Safford <safford@...son.ibm.com>,
	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>
Subject: Re: [PATCH v1.5 5/5] keys: add new key-type encrypted

Mimi Zohar <zohar@...ux.vnet.ibm.com> wrote:

> > > +static struct key *request_trusted_key(const char *trusted_desc,
> > > +				       u8 **master_key,
> > > +				       unsigned int *master_keylen)
> > 
> > You need to annotate the function with an __acquires() to indicate that it
> > returns with a lock held for Sparse checking.  I think you should be able to
> > do:
> > 
> > 	__acquires(tkey->sem)
> 
> hm, only after addding '__acquires' are there Sparse errors.

Leave it, then.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/