linux-kernel - Re: [PATCH] syslog: check cap_syslog when dmesg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1291826783.3072.41.camel@localhost.localdomain>
Date:	Wed, 08 Dec 2010 11:46:23 -0500
From:	Eric Paris <eparis@...hat.com>
To:	"Serge E. Hallyn" <serge@...lyn.com>
Cc:	James Morris <jmorris@...ei.org>,
	Stephen Smalley <sds@...ho.nsa.gov>, dwalsh@...hat.com,
	Kees Cook <kees.cook@...onical.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] syslog: check cap_syslog when dmesg_restrict

On Wed, 2010-12-08 at 16:42 +0000, Serge E. Hallyn wrote:
> Quoting Eric Paris (eparis@...hat.com):

> >   I think the code might be
> > incorrect today as well......
> > 
> > I thought the flow was supposed to be
> > 
> > if (capable(CAP_SYSLOG))
> > 	all good
> > else if (capable(CAP_SYS_ADMIN))
> > 	WARN, but still good for now
> 
> I prefer warn and deny.  Otherwise it's too easy to ignore warnings.  So
> I prefer the msg to be there to explain why it failed - not that I expect
> it to fail for anyone today.

Ok, fine with me.

Acked-by: Eric Paris <eparis@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/