linux-kernel - Re: [PATCH v5 resend] OLPC: Add XO-1 suspend/resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinh9RyGAKeL4weN5bWQ=pAn0NwKdb8Ru4RKkDP3@mail.gmail.com>
Date:	Wed, 8 Dec 2010 22:56:50 +0000
From:	Daniel Drake <dsd@...top.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	mingo@...hat.com, tglx@...utronix.de, hpa@...or.com,
	x86@...nel.org, linux-kernel@...r.kernel.org, dilinger@...ued.net
Subject: Re: [PATCH v5 resend] OLPC: Add XO-1 suspend/resume support

On 8 December 2010 22:50, Andrew Morton <akpm@...ux-foundation.org> wrote:
> x86_64 allmodconfig gives me
>
> {standard input}: Assembler messages:
> {standard input}:300: Error: suffix or operands invalid for `mov'

Thanks, will check. this indeed won't work on x86_64, need to get it
excluded there.

> Also, this checkpatch warning
>
> WARNING: struct platform_suspend_ops should normally be const
> #502: FILE: arch/x86/platform/olpc/xo1.c:106:
> +static struct platform_suspend_ops xo1_suspend_ops = {
>
> seems valid.

When you correct it (to make it const), gcc gives a warning, because
suspend_set_ops() takes non-const arg. I was thinking that casting
const to non-const would be worse than checkpatch warning.

Also working on the extensive feedback from Thomas, next version will
be cleaner and clearer.

Thanks!
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/