linux-kernel - Re: format and standards issues fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 9 Dec 2010 10:43:44 +0200
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Jeffrin Jose <ahiliation@...oo.co.in>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: format and standards issues fixes

On Thu, Dec 09, 2010 at 01:01:26PM +0530, Jeffrin Jose wrote:
> @@ -152,15 +151,14 @@ extern int msnd_pinnacle_init(void);
>  #ifdef CONFIG_SOUND_OSS_CORE_PRECLAIM
>  static int preclaim_oss = 1;
>  #else
> -static int preclaim_oss = 0;
> +static int preclaim_oss = -1;

You didn't understand that warning, do you?

> @@ -252,8 +248,9 @@ static DEFINE_SPINLOCK(sound_loader_lock);
>   *	list. Acquires locks as needed
>   */
>  
> -static int sound_insert_unit(struct sound_unit **list, const struct file_operations *fops, int index, int low, int top, const char *name, umode_t mode, struct device *dev)
> -{
> +static int sound_insert_unit(struct sound_unit **list, const struct \
> +file_operations *fops, int index, int low, int top, const char *name,\
> +umode_t mode, struct device *dev) {

You're splitting lines in unexpected places, so unexpected, that nobody
thought of them before.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/