linux-kernel - [PATCH] x86: Fix warning in hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=rcc38QzoKa6LFy4m++-p_9=Zt4_kDQE=GeKxf@mail.gmail.com>
Date:	Thu, 9 Dec 2010 14:47:34 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Don Zickus <dzickus@...hat.com>, x86@...nel.org,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: [PATCH] x86: Fix warning in hw_nmi.c

commit 0e2af2a9abf94b408ff70679b692a8644fed4aab fixed this warning, it
again introduced by commit 5f2b0ba4d94b3ac23cbc4b7f675d98eb677a760a.
This patch fixes it by moving arch_trigger_all_cpu_backtrace few lines
above backtrace_mask's declaration.

We were warned by the following warning:

arch/x86/kernel/apic/hw_nmi.c:29: warning: ‘backtrace_mask’ defined but not used


Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>
---

diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c
index a0e71cb..0c294b3 100644
--- a/arch/x86/kernel/apic/hw_nmi.c
+++ b/arch/x86/kernel/apic/hw_nmi.c
@@ -25,10 +25,11 @@ u64 hw_nmi_get_sample_period(void)
 #endif


+#ifdef arch_trigger_all_cpu_backtrace
+
 /* For reliability, we're prepared to waste bits here. */
 static DECLARE_BITMAP(backtrace_mask, NR_CPUS) __read_mostly;

-#ifdef arch_trigger_all_cpu_backtrace
 void arch_trigger_all_cpu_backtrace(void)
 {
 	int i;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/