Message-ID: <s5htyinw45f.wl%tiwai@suse.de>
Date:	Thu, 09 Dec 2010 12:56:44 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Maxim Levitsky <maximlevitsky@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Alex Dubov <oakad@...oo.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Aries Lee <arieslee@...cron.com>
Subject: Re: [PATCH 1/2] memstick: add support for legacy memorysticks

At Thu, 09 Dec 2010 08:19:47 +0100,
Takashi Iwai wrote:
> 
> At Thu,  9 Dec 2010 04:42:25 +0200,
> Maxim Levitsky wrote:
> > 
> > Based partialy on spec quotes from Alex Dubov.
> > 
> > As any code that works with user data this driver isn't recommened to use
> > with valuable data.
> > 
> > It tries its best though to avoid data corruption and possible damage to
> > the card.
> > 
> > Tested with MS DUO 64 MB card on Ricoh and Jmicron reader.
> > 
> > Signed-off-by: Maxim Levitsky <maximlevitsky@...il.com>
> 
> Oh, this is interesting.  Just now I looked for a solution for the old
> MS with new JMicron controllers.  (I should have checked mm tree
> beforehand...)
> 
> I'll give it a try and report back later.

I tried your patch now.
But got a WARNING and errors without working properly:

[   86.894497] WARNING: at drivers/memstick/core/ms_block.c:255 msb_run_state_machine+0x90/0xb0 [ms_block]()
[   86.894502] Hardware name:  
[   86.894504] Modules linked in: ms_block(+) nls_iso8859_1 nls_cp437 vfat fat mmc_block netconsole configfs nfs lockd nfs_acl auth_rpcgss sunrpc af_packet i915 drm_kms_helper drm i2c_algo_bit snd_pcm_oss cpufreq_conservative snd_mixer_oss cpufreq_userspace snd_seq cpufreq_powersave acpi_cpufreq mperf binfmt_misc snd_seq_device edd ipv6 fuse loop dm_mod acpiphp pci_hotplug snd_hda_codec_hdmi snd_hda_codec_idt processor rtc_cmos snd_hda_intel snd_hda_codec snd_hwdep snd_pcm snd_timer uvcvideo video thermal thermal_sys snd rtc_core sr_mod soundcore snd_page_alloc sdhci_pci hwmon videodev cdrom r8169 rtc_lib v4l1_compat tpm_tis tpm intel_agp tpm_bios pcspkr hp_accel intel_gtt iTCO_wdt jmb38x_ms memstick sdhci mmc_core mii iTCO_vendor_support sg joydev lis3lv02d serio_raw i2c_core input_polldev output wmi container button battery ac ata_piix sd_mod crc_t10dif ehci_hcd ahci libahci libata usbcore scsi_mod ext3 jbd mbcache
[   86.895023] Pid: 4606, comm: modprobe Not tainted 2.6.37-rc5-test #2
[   86.895037] Call Trace:
[   86.895048]  [<f84fa460>] ? msb_run_state_machine+0x90/0xb0 [ms_block]
[   86.895062]  [<f84fa460>] ? msb_run_state_machine+0x90/0xb0 [ms_block]
[   86.895080]  [<c0241d6c>] warn_slowpath_common+0x6c/0xa0
[   86.895092]  [<f84fa460>] ? msb_run_state_machine+0x90/0xb0 [ms_block]
[   86.895105]  [<f84fc280>] ? h_msb_reset+0x0/0x90 [ms_block]
[   86.895118]  [<c0241dbd>] warn_slowpath_null+0x1d/0x20
[   86.895132]  [<f84fa460>] msb_run_state_machine+0x90/0xb0 [ms_block]
[   86.895151]  [<f84fa52c>] msb_reset+0xac/0x130 [ms_block]
[   86.895169]  [<f84fc9db>] msb_probe+0x6b/0xcc8 [ms_block]
[   86.895175]  [<c0337345>] ? sysfs_addrm_finish+0x15/0xc0
[   86.895187]  [<c0337d75>] ? sysfs_do_create_link+0xb5/0x1b0
[   86.895191]  [<c0337345>] ? sysfs_addrm_finish+0x15/0xc0
[   86.895212]  [<f92ba344>] memstick_device_probe+0x34/0x50 [memstick]
[   86.895228]  [<c042cbf5>] driver_probe_device+0x95/0x280
[   86.895233]  [<c038be9a>] ? kobject_add_internal+0xca/0x210
[   86.895249]  [<c0395543>] ? kvasprintf+0x43/0x60
[   86.895252]  [<c042ce59>] __driver_attach+0x79/0x80
[   86.895256]  [<c042c3d3>] bus_for_each_dev+0x53/0x80
[   86.895274]  [<f92ba2b0>] ? memstick_device_remove+0x0/0x50 [memstick]
[   86.895278]  [<c042c9f9>] driver_attach+0x19/0x20
[   86.895290]  [<c042cde0>] ? __driver_attach+0x0/0x80
[   86.895292]  [<c042bcc7>] bus_add_driver+0x197/0x280
[   86.895297]  [<f92ba2b0>] ? memstick_device_remove+0x0/0x50 [memstick]
[   86.895308]  [<c042d0f5>] driver_register+0x75/0x160
[   86.895313]  [<c0381f18>] ? register_blkdev+0xf8/0x130
[   86.895326]  [<f8234000>] ? msb_init+0x0/0x6d [ms_block]
[   86.895332]  [<f92ba422>] memstick_register_driver+0x12/0x20 [memstick]
[   86.895337]  [<f8234035>] msb_init+0x35/0x6d [ms_block]
[   86.895351]  [<c020112b>] do_one_initcall+0x2b/0x160
[   86.895365]  [<c0273943>] sys_init_module+0x93/0x1d0
[   86.895377]  [<c0202d98>] sysenter_do_call+0x12/0x28
[   86.895381] ---[ end trace 0f1b7248462dd657 ]---
[   86.895593] ms_block: Switch to parallel failed
[   86.908121] ms_block: Switch to parallel failed

And "switch to parallel failed" continues endlessly until you unplug.
Also, at another time, the machine got frozen with plugging.

After unplugging:

[   91.398455] ms_block: read of pba 0, page 0 failed with error -62
[   91.414437] ms_block: read of pba 1, page 0 failed with error -62
[   91.430412] ms_block: read of pba 2, page 0 failed with error -62
[   91.446389] ms_block: read of pba 3, page 0 failed with error -62
[   91.462370] ms_block: read of pba 4, page 0 failed with error -62
[   91.478242] ms_block: read of pba 5, page 0 failed with error -62
[   91.494224] ms_block: read of pba 6, page 0 failed with error -62
[   91.510205] ms_block: read of pba 7, page 0 failed with error -62
[   91.526187] ms_block: read of pba 8, page 0 failed with error -62
[   91.542163] ms_block: read of pba 9, page 0 failed with error -62
[   91.558145] ms_block: read of pba 10, page 0 failed with error -62
[   91.574127] ms_block: read of pba 11, page 0 failed with error -62
[   91.574153] ms_block: media doesn't contain master page, aborting
[   91.574176] ms_block: probe of memstick0 failed with error -5


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists