linux-kernel - Aw: Re: [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs attribute creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Dec 2010 14:44:06 +0100 (CET)
From:	Stefan Achatz <erazor_de@...rs.sourceforge.net>
To:	jkosina@...e.cz, erazor_de@...rs.sourceforge.net
Cc:	rdunlap@...otime.net, gregkh@...e.de, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Aw: Re: [PATCH 0/5] HID: roccat: Achieve userspace notification on
 sysfs attribute creation

 


----- Original Nachricht ----
Von:     Jiri Kosina <jkosina@...e.cz>
An:      Stefan Achatz <erazor_de@...rs.sourceforge.net>
Datum:   09.12.2010 14:30
Betreff: Re: [PATCH 0/5] HID: roccat: Achieve userspace notification on sysfs
 attribute creation

> On Fri, 26 Nov 2010, Stefan Achatz wrote:
> 
> > Adding sysfs attributes to an already created device raises no userland
> > notification.
> > 
> > Instead of fiddling around in the depths of busses and devices I reuse
> the
> > event char device (module hid-roccat). This device gets now created with
> > a hardware specific class that contains the device attributes.
> 
> Hi Stefan,
> 
> I have applied the series, and removed the #pragma pack ugliness. Thanks,

Hello Jiri,
Using my patch replacing the #pragma pack with the __packed macro would have saved you some time:
https://lkml.org/lkml/2010/11/27/14

Just for the future: Whats better using the verbose version __attribute__ ((__packed__)) or the macro
__packed as I did?

Thanks, Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/