linux-kernel - Re: [tip:sched/urgent] Sched: fix skip_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1291908773.29292.16.camel@twins>
Date:	Thu, 09 Dec 2010 16:32:53 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	efault@....de, bbb.lst@...il.com, tglx@...utronix.de,
	yong.zhang0@...il.com, mingo@...e.hu
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/urgent] Sched: fix skip_clock_update optimization

On Wed, 2010-12-08 at 20:40 +0000, tip-bot for Mike Galbraith wrote:
> @@ -4063,6 +4062,8 @@ need_resched_nonpreemptible:
>  
>         put_prev_task(rq, prev);
>         next = pick_next_task(rq);
> +       clear_tsk_need_resched(prev);
> +       rq->skip_clock_update = 0;
>  
>         if (likely(prev != next)) {
>                 sched_info_switch(prev, next);
> @@ -4071,6 +4072,7 @@ need_resched_nonpreemptible:
>                 rq->nr_switches++;
>                 rq->curr = next;
>                 ++*switch_count;
> +               WARN_ON_ONCE(test_tsk_need_resched(next)); 

I just managed to trigger this one.. will try and reproduce to find out
wth happened.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/