linux-kernel - Re: [PATCH] [USB] UASP: USB Attached SCSI (UAS) protocol driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Dec 2010 17:52:04 -0800
From:	Greg KH <greg@...ah.com>
To:	Luben Tuikov <ltuikov@...oo.com>
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] [USB] UASP: USB Attached SCSI (UAS) protocol driver

On Wed, Dec 08, 2010 at 04:16:06PM -0800, Luben Tuikov wrote:
> --- On Mon, 12/6/10, Greg KH <greg@...ah.com> wrote:
> >
> > We already have this support in the kernel tree,
> 
> Greg, this isn't an effort for "linux kernel code turf".  This is a
> well-implemented driver according to the respective specifications
> (SAM, SPC, USB 2/3). It reflects correct implementation, naming, etc.
> It shows understanding of the abstraction layers and underlying
> technology. It's what you'd want to have in /YOUR/ kernel.

What I don't want in _anyones_ kernel is multiple drivers wanting to
attach to the same device.

> > why do you want and need another driver that does the same exact thing?
> 
> Nothing can be further from the truth. The current uas.c driver
> doesn't do the "exact same thing", far from it.
> 
> You responded 4 minutes after my post. Did you have to time to verify
> that the driver I posted does "the exact same thing" as the one in the
> kernel?

By "same thing" I mean "binds to the same device."

I have lived through the hell of this in the past and I will not let
that happen again, sorry.

> 
> "The exact same thing", let's see:

<snip>

I'm not saying that the in-kernel driver is perfect at all, and it's
author is getting annoying by refusing to answer my emails, but still,
please work with him to get the in-kernel driver to work up to your
needs.

If you have problems with the maintainer, please let me know and I'll
see what I can do.

But again, this driver is not acceptable as-is, sorry.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/