linux-kernel - Re: [RFC] Input: define separate EVIOCGKEYCODE_V2/EVIOCSKEYCODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D012844.3020009@euromail.se>
Date:	Thu, 09 Dec 2010 20:04:36 +0100
From:	Henrik Rydberg <rydberg@...omail.se>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Linux Input <linux-input@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, linux-media@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Jiri Kosina <jkosina@...e.cz>, Jarod Wilson <jarod@...hat.com>,
	David Härdeman <david@...deman.nu>
Subject: Re: [RFC] Input: define separate EVIOCGKEYCODE_V2/EVIOCSKEYCODE_V2

On 12/09/2010 10:39 AM, Dmitry Torokhov wrote:

> The desire to keep old names for the EVIOCGKEYCODE/EVIOCSKEYCODE while
> extending them to support large scancodes was a mistake. While we tried
> to keep ABI intact (and we succeeded in doing that, programs compiled
> on older kernels will work on newer ones) there is still a problem with
> recompiling existing software with newer kernel headers.
> 
> New kernel headers will supply updated ioctl numbers and kernel will
> expect that userspace will use struct input_keymap_entry to set and
> retrieve keymap data. But since the names of ioctls are still the same
> userspace will happily compile even if not adjusted to make use of the
> new structure and will start miraculously fail in the field.
> 
> To avoid this issue let's revert EVIOCGKEYCODE/EVIOCSKEYCODE definitions
> and add EVIOCGKEYCODE_V2/EVIOCSKEYCODE_V2 so that userspace can explicitly
> select the style of ioctls it wants to employ.
> 
> Signed-off-by: Dmitry Torokhov <dtor@...l.ru>
> ---


Would the header change suffice in itself? Either way, also checked that the
bugfixes following the original patch is still in effect, so looks ok to me.

Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/