linux-kernel - Re: [PATCH] Update MCP55 quirk to not affect non HyperTransport variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101209154041.8a54dba8.akpm@linux-foundation.org>
Date:	Thu, 9 Dec 2010 15:40:41 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Neil Horman <nhorman@...driver.com>
Cc:	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	kexec@...ts.infradead.org, Vivek Goyal <vgoyal@...hat.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH] Update MCP55 quirk to not affect non HyperTransport
 variants

On Wed,  8 Dec 2010 09:47:48 -0500
Neil Horman <nhorman@...driver.com> wrote:

> I wrote this quirk awhile ago to properly setup MCP55 chips on hypertransport
> busses so that interrupts reached whatever cpu happend to boot the kdump kernel.
> while that works well, it was recently shown to me that a a non-hypertransport
> variant of the MCP55 exists, and on those system the register that this quirk
> manipulates causes hangs if you write to it.  Since the quirk was only meant to
> handle errors found on MCP55 chips that have a HT interface, this patch adds a
> filter to make sure the chip is an HT capable before making the needed register
> adjustment.  This lets the broken MCP55s work with kdump while not breaking the
> non-HT variants.
> 
> Resolves https://bugzilla.kernel.org/show_bug.cgi?id=23952
> 
> Tested successfully by the reporter and myself.
> 
> Reported-by: Mathieu B__rard <mathieu@...rard.eu>
> CC: linux-pci@...r.kernel.org
> CC: kexec@...ts.infradead.org
> CC: Vivek Goyal <vgoyal@...hat.com>
> CC: Jesse Barnes <jbarnes@...tuousgeek.org>
> Signed-off-by: Neil Horman <nhorman@...driver.com>

That needed a Cc:<stable@...nel.org> as well.  Please don't forget to
remember -stable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/