linux-kernel - Re: [PATCH] intel-iommu: Fix use after release during device attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D01E677.5070702@siemens.com>
Date:	Fri, 10 Dec 2010 09:36:07 +0100
From:	Jan Kiszka <jan.kiszka@...mens.com>
To:	Sheng Yang <sheng@...ux.intel.com>,
	David Woodhouse <dwmw2@...radead.org>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	kvm <kvm@...r.kernel.org>, Avi Kivity <avi@...hat.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	iommu@...ts.linux-foundation.org
Subject: Re: [PATCH] intel-iommu: Fix use after release during device attach

Am 14.11.2010 10:18, Jan Kiszka wrote:
> Am 02.11.2010 08:31, Sheng Yang wrote:
>> On Tuesday 02 November 2010 15:05:51 Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@...mens.com>
>>>
>>> Obtail the new pgd pointer before releasing the page containing this
>>> value.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
>>> ---
>>>
>>> Who is taking care of this? The kvm tree?
>>>
>>>  drivers/pci/intel-iommu.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
>>> index 4789f8e..35463dd 100644
>>> --- a/drivers/pci/intel-iommu.c
>>> +++ b/drivers/pci/intel-iommu.c
>>> @@ -3627,9 +3627,9 @@ static int intel_iommu_attach_device(struct
>>> iommu_domain *domain,
>>>
>>>  		pte = dmar_domain->pgd;
>>>  		if (dma_pte_present(pte)) {
>>> -			free_pgtable_page(dmar_domain->pgd);
>>>  			dmar_domain->pgd = (struct dma_pte *)
>>>  				phys_to_virt(dma_pte_addr(pte));
>>> +			free_pgtable_page(pte);
>>>  		}
>>>  		dmar_domain->agaw--;
>>>  	}
>>
>> Reviewed-by: Sheng Yang <sheng@...ux.intel.com>
>>
>> CC iommu mailing list and David.
> 
> Ping...
> 
> I think this fix also qualifies for stable (.35 and .36).
> 

Still not merged?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/