linux-kernel - Re: [PATCH] [USB] UAS: Use kzalloc instead of kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <823199.4758.qm@web31810.mail.mud.yahoo.com>
Date:	Fri, 10 Dec 2010 02:49:53 -0800 (PST)
From:	Luben Tuikov <ltuikov@...oo.com>
To:	Greg KH <greg@...ah.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	willy@...ux.intel.com
Subject: Re: [PATCH] [USB] UAS: Use kzalloc instead of kmalloc

Patch retracted for this still-born driver. Instead please use superior uasp.c which was recently submitted.

--- On Wed, 10/27/10, Luben Tuikov <ltuikov@...oo.com> wrote:

> From: Luben Tuikov <ltuikov@...oo.com>
> Subject: [PATCH] [USB] UAS: Use kzalloc instead of kmalloc
> To: "Greg KH" <greg@...ah.com>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org, willy@...ux.intel.com
> Date: Wednesday, October 27, 2010, 1:22 PM
> "Be conservative in what you send,
> liberal in what
> you accept." -- In the spirit of this adage, don't
> send Command IUs with randomly filled in data in
> the reserved fields. (Yes, this shows up on the
> wire.)
> 
> Signed-off-by: Luben Tuikov <ltuikov@...oo.com>
> ---
>  drivers/usb/storage/uas.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/storage/uas.c
> b/drivers/usb/storage/uas.c
> index 2054b1e..17e1820 100644
> --- a/drivers/usb/storage/uas.c
> +++ b/drivers/usb/storage/uas.c
> @@ -294,7 +294,7 @@ static struct urb
> *uas_alloc_sense_urb(struct uas_dev_info *devinfo, gfp_t
> gfp,
>      if (!urb)
>          goto out;
>  
> -    iu = kmalloc(sizeof(*iu), gfp);
> +    iu = kzalloc(sizeof(*iu), gfp);
>      if (!iu)
>          goto free;
>  
> @@ -325,7 +325,7 @@ static struct urb
> *uas_alloc_cmd_urb(struct uas_dev_info *devinfo, gfp_t gfp,
>      if (len < 0)
>          len = 0;
>      len = ALIGN(len, 4);
> -    iu = kmalloc(sizeof(*iu) + len, gfp);
> +    iu = kzalloc(sizeof(*iu) + len, gfp);
>      if (!iu)
>          goto free;
>  
> @@ -660,7 +660,7 @@ static int uas_probe(struct
> usb_interface *intf, const struct usb_device_id *id)
>             
> return -ENODEV;
>      }
>  
> -    devinfo = kmalloc(sizeof(struct
> uas_dev_info), GFP_KERNEL);
> +    devinfo = kzalloc(sizeof(struct
> uas_dev_info), GFP_KERNEL);
>      if (!devinfo)
>          return -ENOMEM;
>  
> -- 
> 1.7.0.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/