linux-kernel - Re: [PATCH] ALSA: aoa: Remove wrong i2c_set_clientdata in onyx_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <s5h4oal3mll.wl%tiwai@suse.de>
Date:	Fri, 10 Dec 2010 12:15:34 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Johannes Berg <johannes@...solutions.net>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] ALSA: aoa: Remove wrong i2c_set_clientdata in	onyx_i2c_remove()

At Fri, 10 Dec 2010 17:34:26 +0800,
Axel Lin wrote:
> 
> It does not make sense to set clientdata to onyx in onyx_i2c_remove()
> as we are going to kfree onyx.
> What we really want here is i2c_set_clientdata(client, NULL);
> Since the i2c core will take care of it now, so this patch just removes it.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Thanks, applied now.


Takashi

> ---
>  sound/aoa/codecs/onyx.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
> index 91852e4..3687a6c 100644
> --- a/sound/aoa/codecs/onyx.c
> +++ b/sound/aoa/codecs/onyx.c
> @@ -1114,7 +1114,6 @@ static int onyx_i2c_remove(struct i2c_client *client)
>  	of_node_put(onyx->codec.node);
>  	if (onyx->codec_info)
>  		kfree(onyx->codec_info);
> -	i2c_set_clientdata(client, onyx);
>  	kfree(onyx);
>  	return 0;
>  }
> -- 
> 1.7.2
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/