linux-kernel - Re: [RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from cs during transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101210114604.GB4228@pengutronix.de>
Date:	Fri, 10 Dec 2010 12:46:04 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Ben Gardiner <bengardiner@...ometrics.ca>
Cc:	spi-devel-general@...ts.sourceforge.net,
	Grant Likely <grant.likely@...retlab.ca>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	linux-kernel@...r.kernel.org, Michael Buesch <mb@...sch.de>
Subject: Re: [RFC][PATCH v2 2/3] spi_bitbang : get nsecs delay from cs
 during transfer

Hi,

thanks for the submission. It has some issues, though:

On Thu, Dec 09, 2010 at 03:34:55PM -0500, Ben Gardiner wrote:

> +		nsecs =
> +#if defined(CONFIG_SLOWER_SPI_GPIO)
> +				!cs->nsecs ? cs->nsecs : 100;
> +#else
> +		100;
> +#endif

This coding style is very hard to read and gains nothing for it. Also,
slower_spi should rather be a per-device than a config option.

Kind regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)